New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Update SQL Server Offset #44355

Closed

dunhamjared wants to merge 2 commits into laravel:9.x from dunhamjared:9.x

Contributor

dunhamjared commented Sep 28, 2022 •

edited

This PR helps reduce query select conflicts and removes unexpected data generated by laravel.

Changes:

Renamed temporary column row_num to temp_row_num to help reduce conflicts
Removes the temp_row_num column from the results if offset used

Fixes #44354

Jared Dunham added 2 commits

September 28, 2022 12:44


          fix sql server offset

95b9124


          StyleCI fix

b42395e

Member

taylorotwell commented Sep 29, 2022

Would need more feedback from SQL Server users here.

taylorotwell closed this

dunhamjared mentioned this pull request

[10.x] Possible fix for unexpected column in SQL Server offset #44377

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment