[9.x] Test on PHP 8.2 #43910
Merged
[9.x] Test on PHP 8.2 #43910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
driesvints
commented
Sep 1, 2022
| /** | ||
| * The request cookies. | ||
| * | ||
| * @var \GuzzleHttp\Cookie\CookieJar |
There was a problem hiding this comment.
It's odd since on PendingRequest this is an array. Not sure why it's different here.
driesvints
force-pushed
the
php82-support
branch
from
b601be5
to
2350ddf
Compare
driesvints
force-pushed
the
php82-support
branch
from
460cdb7
to
d9bdae3
Compare
stof
reviewed
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at providing a passing build for PHP 8.2
Depends on:
Fix PHP 8.2 issues ably/ably-php#167(disabled PHP 8.2 testing for now)${var}string interpolation deprecation dragonmantank/cron-expression#142