[8.x] clear Facade resolvedInstances in queue worker resetScope callback #43215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Jul 18, 2022
ankorstore-haddowg
force-pushed
the
fix/clear-facade-resolved-bindings-on-worker-rest-scope
branch
from
6b9e17e
to
fbe80ce
Compare
… ensure scoped bindings are cleared.
ankorstore-haddowg
force-pushed
the
fix/clear-facade-resolved-bindings-on-worker-rest-scope
branch
from
fbe80ce
to
0577815
Compare
|
Thanks @ankorstore-haddowg |
ankorstore-haddowg
deleted the
fix/clear-facade-resolved-bindings-on-worker-rest-scope
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43151
Ensure scoped bindings are cleared from resolved facade instances when a worker resets its scope, as per https://github.com/laravel/octane/blob/1.x/src/CurrentApplication.php#L24