[9.x] Fix route:list --except-vendor hiding Route::view() & Route::redirect()
#41465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmd
force-pushed
the
route-list-illuminate-magic-routes
branch
from
9370c7f
to
57bd20b
Compare
Don't consider Illuminate\Routing\RedirectController & ViewController as vendor-registered routes. Assume Route::view() or Route::redirect() were called in userland routes/*.php.
derekmd
force-pushed
the
route-list-illuminate-magic-routes
branch
from
57bd20b
to
593697d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41416
This doesn't show paths registered via
Route::view()orRoute::redirect().Don't consider
Illuminate\Routing\RedirectController&Illuminate\Routing\ViewControlleras vendor-registered routes. AssumeRoute::view()orRoute::redirect()were called in userland routes/*.php.To more accurately track this,
Illuminate\Routing\Routeneeds a new class property$isVendor. The constructor would traverse its stacktrace to find the originating call. It could be anapp()->environment('development', 'testing')-onlycode path but I don't think the
Routeclass bloat is worth it considering these "magic route" methods are more a userland feature than packageland. It could also introduce a breaking change to serializing routes.