Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Implement email "metadata" for SesTransport #41422

Merged
merged 1 commit into from Mar 10, 2022

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Mar 10, 2022

This adds metadata support for the SesTransport. This was added in Symfony core (symfony/symfony#45222) but won't be available until 6.1.

SES calls these "tags" but by our definition, they are metadata. SES does not have the concept of "tags" by our definition.

Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@taylorotwell
Copy link
Member

@kbond can you point me to where "tags" and "metadata" are clearly defined from Symfony mailer's perspective? What is the purpose of a tag and what is the purpose of metadata? It feels like it would be great to have documentation on what each type (tag / metadata) does for each driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants