[9.x] Remove useless reduceWithKeys method
#40566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSilber
force-pushed
the
remove-useless-reduce-with-keys
branch
from
df45ac7
to
8ae8e34
Compare
|
What is the migration path for those using this method already when upgrading from 8.x? Please mark as ready for review when provided. |
|
Simply switch their uses of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original introduction of
reduceWithKeyswas kind of not ideal for two reasons: the name is inconsistent with the other*WithKeysmethod, and it really should've never been a separate method -reduceitself could handle keys too....and that's what we ultimately did: we added
$keysupport to the regularreducemethod.We decided to keep
reduceWithKeysin 8.x, and then remove it completely in 9.x. I think #35901 was trying to do that, but evidently it's still around. So this PR removes it.