[8.x] Customize type column in database notifications using databaseType me…

[mvaliolahi]

By this pull request, we can customize the type column in the database notifications.

By default, Laravel use class_name($notification) for the type column, and this can be undesirable on the client-side.

class InvoiceNotification extends Notification implements ShouldQueue {

    public function via($notifiable)
    {
        return ['database'];
    }

    public function databaseType() 
    {
        return 'DAILY';
    }

[driesvints]

Are you completely sure this actually works? Have you tested this in a real Laravel application? I've been trying to do this myself a couple of times but there was always a snag I ran into. Can't exactly remember which ones though 🤔

[mvaliolahi]

Yes, I test it, and works for me.

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

[mvaliolahi]

@taylorotwell Thanks for the reply, This PR is similar to Relation::enforceMorphMap and I am not convinced!

Notification record in DB is like below:

{
"notifications": [
	{
		"id" : "",
		"type" : "App\\Notifications\\LikeNotification",
		"notifiable_type" : "",
		"notifiable_id" :,
		"data" : "{}",
		"read_at" : ,
		"created_at" : "",
		"updated_at" : ""
	},
]}