Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Add App::isDebug() method to detect debug mode #39755

Merged
merged 4 commits into from Nov 25, 2021
Merged

[8.x] Add App::isDebug() method to detect debug mode #39755

merged 4 commits into from Nov 25, 2021

Commits on Nov 24, 2021

  1. add App::isDebug() method to detect debug mode 

    Like App::isLocal(), isProduction(), runningInConsole(), isLocale(), etc. it makes sense to have a method on the Container to detect debug mode.

I struggled with the method name, but isDebug() sort of matches most of the methods with similar functionality. I also like:

* debugMode()
* debugEnabled()
* debugModeEnabled()
* inDebugMode()
    @joelmellon
    joelmellon committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    9be9e87 View commit details
    Browse the repository at this point in the history

  2. add isDebug() unit test

    @joelmellon
    joelmellon committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    f245a6c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Update Application.php

    @taylorotwell
    taylorotwell committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    1fe1076 View commit details
    Browse the repository at this point in the history

  2. Update FoundationApplicationTest.php

    @taylorotwell
    taylorotwell committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    e330c59 View commit details
    Browse the repository at this point in the history