[8.x] Use parents to resolve middleware priority #39647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're going to have to revert this: 404labfr/laravel-impersonate#145 & #39705 |
driesvints
added a commit
that referenced
this pull request
Nov 19, 2021
This reverts commit cfab148.
taylorotwell
pushed a commit
that referenced
this pull request
Nov 20, 2021
|
@driesvints I'm pretty sure the package has some bugs in it but probably it's best to revert it and I will target 9.x later if I have some time |
|
@netpok as said in the other thread: it would be good if we could identify the bug itself so we know how this will impact others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when middlewares are ordered it uses the class name and its interfaces for sorting but not it's parents.
This is a problem for example in Jetstream because:
AuthenticateSessionmiddleware with it's own.AuthenticatemiddlewareThis PR fixes this behaviour by using parent classes for ordering so the Jetstream
AuthenticateSessionmiddleware will be in the correct place because it extends the LaravelAuthenticateSessionmiddleware.I also added test for the parent sorting and the already present interface sorting.