fix(rollback) required_if and exclude_if validation

[s4muel]

i think you do not want to return early in these cases as @driesvints changed in this PR: #37128
that PR broke using this validation for null values (e.g. checkboxes that are not checked) so you cannot use it like exclude_if,otherfield,null

[driesvints]

Yes you do. This was a vital part of the fix. The problem is that you're not using nullable in the validation rules.

[s4muel]

hm, the checkbox (otherfield in my example), even if nullable, is not present in $this->data, so this always passes: https://github.com/laravel/framework/blob/8.x/src/Illuminate/Validation/Concerns/ValidatesAttributes.php#L1615

[driesvints]

Please post the full validation rules and data that's being passed so we can reproduce this.

[s4muel]

minimum to reproduce:
validation rules:

[
    'email' => 'exclude_if:owner,null|email',
    'owner' => 'nullable',
]

form contains two inputs:
email: text input field
owner: checkbox

submit form with empty email and unchecked checkbox
dump of $request->input():

[
  "_token" => "rjGnNZQ2OP9oqRQtn7y6yKFK8izvlh4wFXiRtSGF"
  "email" => null
  "send" => "Submit"
]

the email is not excluded and it fails on 'email' rule.

note: if i switch the logic around and use exclude_unless

[
    'email' => 'exclude_unless:owner,on|email',
    'owner' => 'nullable',
]

it works as expected

[driesvints]

This is with your example. Like I said: you need to add nullable to your email rule:

[s4muel]

oh, i see. kind of makes sense now. and since i want that email not to be null if the checkbox is true, i need a sometimes rule instead of nullable ('email' => 'exclude_if:owner,null|sometimes|email'). at least it seems to be working.

it wasnt clear though and when i updated laravel recently (from 8.38.0 to 8.68.1) my tests just broke (phew, at least i got that covered) because of that PR mentioned earlier. it previously worked like that so i got false understanding how it should work.

thank you!

[driesvints]

@s4muel no worries. Glad you got that fixed 👍