Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Return a new or existing guzzle client based on context #38642

Merged
merged 3 commits into from Sep 2, 2021
Merged

[8.x] Return a new or existing guzzle client based on context #38642

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64ed229
Return a new or existing guzzle client based on context
craigballinger Sep 2, 2021
13d2e6f
StyleCI fixes
craigballinger Sep 2, 2021
1fdc005
Update PendingRequest.php
taylorotwell Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/Illuminate/Http/Client/PendingRequest.php
View file
Open in desktop
Expand Up @@ -798,6 +798,28 @@ protected function populateResponse(Response $response)
* @return \GuzzleHttp\Client
*/
public function buildClient()
{
return $this->requestsReusableClient()
? $this->getReusableClient()
: $this->createClient($this->buildHandlerStack());
}

/**
* Determine if a reusable client is required.
*
* @return bool
*/
protected function requestsReusableClient()
{
return ! is_null($this->client) || $this->async;
}

/**
* Retrieve a reusable Guzzle client.
*
* @return \GuzzleHttp\Client
*/
protected function getReusableClient()
{
return $this->client = $this->client ?: $this->createClient($this->buildHandlerStack());
}
Expand Down