Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Option to use table names when morphing #38451

Merged
merged 4 commits into from
Aug 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,9 @@ public function getMorphClass()
return array_search(static::class, $morphMap, true);
}

return static::class;
return Relation::$useTableNamesForMorphMap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this code is being changed, maybe it would also be useful to add an optional property/method to models (eg. morphableName) that can be used - so each model can represent its own morphable name itself instead of being done elsewhere in a map?

? $this->getTable()
: static::class;
}

/**
Expand Down
17 changes: 17 additions & 0 deletions src/Illuminate/Database/Eloquent/Relations/Relation.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ abstract class Relation
*/
protected static $constraints = true;

/**
* Indicates that table names should be used when determining morph classes.
*
* @var bool
*/
public static $useTableNamesForMorphMap = false;

/**
* An array to map class names to their morph names in the database.
*
Expand Down Expand Up @@ -376,6 +383,16 @@ protected function whereInMethod(Model $model, $key)
: 'whereIn';
}

/**
* Indicate that the table names should be used when determining morphed class names.
*
* @return void
*/
public static function morphUsingTableNames()
{
static::$useTableNamesForMorphMap = true;
}

/**
* Set or get the morph map for polymorphic relations.
*
Expand Down
10 changes: 10 additions & 0 deletions tests/Database/DatabaseEloquentModelTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,16 @@ public function testMorphOneCreatesProperRelation()
$this->assertEquals(EloquentModelStub::class, $relation->getMorphClass());
}

public function testMorphOneCreatesProperRelationWhenUsingTableNames()
{
Relation::morphUsingTableNames();
$model = new EloquentModelStub;
$this->addMockConnection($model);
$relation = $model->morphOne(EloquentModelSaveStub::class, 'morph');
$this->assertEquals('stub', $relation->getMorphClass());
Relation::$useTableNamesForMorphMap = false;
}

public function testCorrectMorphClassIsReturned()
{
Relation::morphMap(['alias' => 'AnotherModel']);
Expand Down