[8.x] Schedule list timezone #37117
Merged
[8.x] Schedule list timezone #37117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Apr 26, 2021
| ->getNextRunDate(Carbon::now()) | ||
| ->setTimezone($this->option('timezone', config('app.timezone'))), | ||
| ->getNextRunDate(Carbon::now()->setTimezone($event->timezone)) | ||
| ->setTimezone($this->option('timezone', config('app.timezone'))) |
There was a problem hiding this comment.
Can't have this foundation config function call.
There was a problem hiding this comment.
Do you mean config('app.timezone')? It was originally there.
Pros: all timezones are based on option/Laravel's .env
Cons: the timezone displayed on output may not be the same as coded, i.e. coded as 0:00 GMT+0, but displayed as 1:00 GMT+1.
My personal preference is to have output displayed as coded.
Actually, I have my own personal schedule:list, I could PR this too if it is welcomed. It has this diffForHumans() and English translation of cron, which helps quite a bit.
There was a problem hiding this comment.
@GrahamCampbell for command's it's okay since they only work with the base foundation anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the timezone output as some of my schedules utilized
->timezone()Also fixed an issue where the
next duewas incorrect.