Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] limit expected bindings v3 #35973

Closed
wants to merge 2 commits into from

Conversation

nfangxu
Copy link

@nfangxu nfangxu commented Jan 21, 2021

I prefer my way. @mpyw

#35865
#35972

@u01jmg3
Copy link
Contributor

u01jmg3 commented Jan 21, 2021

What about whereBetween(), whereJsonLength() and having()?

@KaneCohen
Copy link
Contributor

This is more elegant, however it might have an issue with input like that:

[[], [12, 30]

Array flattening disregards empty array since technically there's no values inside while head() function will return false.

@nfangxu
Copy link
Author

nfangxu commented Jan 21, 2021

This is more elegant, however it might have an issue with input like that:

[[], [12, 30]

Array flattening disregards empty array since technically there's no values inside while head() function will return false.

If this is the case, returning a false is also OK

@nfangxu
Copy link
Author

nfangxu commented Jan 21, 2021

What about whereBetween(), whereJsonLength() and having()?

whereJsonLength() directly (int) limit

whereBetween() and having() has been added

@limingxinleo
Copy link

M

@taylorotwell
Copy link
Member

Saying "I prefer my way" with no explanation isn't going to get anything merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants