New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Pass $key to closure in Collection and LazyCollection's reduce method as well #35878
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
31dbc46
add reduce with keys to collections
mokhosh 4777a54
add reduce with keys to lazy collections
mokhosh 1b788e7
add test for reduce with keys
mokhosh b84aaec
fix style
mokhosh cdbc409
merge reduceWithKeys into the existing reduce method
mokhosh 8bb93ef
Merge branch '8.x' into 8.x
mokhosh fd7213f
remove reduce and reduceWithKeys from Collection
mokhosh 4ff9136
remove reduce and reduceWithKeys from LazyCollection
mokhosh a94adeb
add reduce and reduceWithKeys to EnumeratesValues
mokhosh 11bace2
add test for reduce with keys and reduceWithKeys
mokhosh 88b8169
Merge branch '8.x' into 8.x
mokhosh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduceWithKeys
around till 9.x (because it was already tagged), we shouldn't remove its test.$key
to the other test. No need for 2 separate tests.reduce
method into theEnumeratesValues
trait.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thanks for the comment