Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Use "asRowid" modifier for migrations table #35816

Closed
wants to merge 1 commit into from

Conversation

Max13
Copy link
Contributor

@Max13 Max13 commented Jan 7, 2021

Depends on #35792

Removes the unnecessary sqlite_sequence table created by sqlite to keep track of AUTOINCREMENT values, when creating migrations table on sqlite.

sqlite_sequence will still be created if the user doesn't declare his ids ->asRowid() though…

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants