Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Use alias to 'rowid' when using SQLite #35807

Closed
wants to merge 1 commit into from
Closed

Conversation

Max13
Copy link
Contributor

@Max13 Max13 commented Jan 6, 2021

See #35792

Using this syntax removes the unnecessary sqlite_sequence table created by sqlite to keep track of AUTOINCREMENT values.

This PR makes me wonder if it wouldn't be a better idea to change the way $table->…Increments() are compiled with sqlite instead.

@GrahamCampbell GrahamCampbell changed the title Use alias to 'rowid' when using SQLite [8.x] Use alias to 'rowid' when using SQLite Jan 7, 2021
@Max13
Copy link
Contributor Author

Max13 commented Jan 7, 2021

I have changes to do on this one

@GrahamCampbell GrahamCampbell marked this pull request as draft January 7, 2021 13:35
@GrahamCampbell
Copy link
Member

Mark this as ready to review when you are done.

@driesvints
Copy link
Member

@Max13 just feel free to send this in when you're done.

@driesvints driesvints closed this Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants