[8.x] Add missing dispatchAfterCommit to DatabaseQueue #35715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @themsaid |
|
For the database queue, the dispatching will happen after commit anyway. So this PR is not needed. |
|
I think it could be an issue if the transaction is happening on a different connection than the one holding your jobs table, but that can probably be considered an edge case. In any case, feel free to revert if you think this is not needed. EDIT: Just to make it clear, the original intent of this PR was to align the params being passed in the |
levacic
pushed a commit
to levacic/laravel-framework
that referenced
this pull request
Dec 26, 2020
* add missing dispatchAfterCommit to DatabaseQueue * add new param to phpdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent #35422 missed adding the new
$dispatchAfterCommitparameter to theDatabaseQueue.The new param is being passed in the DatabaseConnector but the queue class was not updated.
I also reformatted the
DatabaseQueueconstructor params (one arg per line) to match the changes in the previous PR.