Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add tests for attaching existing model instances in factories #35581

Merged
merged 1 commit into from Dec 11, 2020
Merged

[8.x] Add tests for attaching existing model instances in factories #35581

merged 1 commit into from Dec 11, 2020

Conversation

bakerkretzmar
Copy link
Contributor

This PR adds tests to cover #35541. Without the changes in that PR, these tests fail—with that PR, they pass.

I opted to duplicate some test code and add relationship names rather than refactor lots of existing tests, but I'm happy to do it that way too if you'd prefer.

@taylorotwell taylorotwell merged commit 3531b36 into laravel:8.x Dec 11, 2020
@bakerkretzmar bakerkretzmar deleted the test-model-instances-in-factories branch December 12, 2020 00:00
@ErickZH
Copy link
Contributor

ErickZH commented Dec 18, 2020

Thanks @bakerkretzmar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants