[8.x] Fix issue with polymorphic morphMaps with literal 0 #35364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iBotPeaches @taylorotwell Thank you for this fix. Could you tell if this change will also be added to 6.x version? |
driesvints
pushed a commit
that referenced
this pull request
Dec 4, 2020
* fix: use strict null check on morphTo type * test: assert 0 relation_type is handled correctly
|
@dmytro-laba I've sent this to 6.x here: #35487. Thanks |
|
@driesvints Thanks a lot! |
taylorotwell
pushed a commit
that referenced
this pull request
Dec 4, 2020
#35364) (#35487) * [8.x] Fix issue with polymorphic morphMaps with literal 0 (#35364) * fix: use strict null check on morphTo type * test: assert 0 relation_type is handled correctly * Use setMethods for 6.x * Update HasRelationships.php Co-authored-by: Connor Tumbleson <iBotPeaches@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Ran into project where
During a legacy upgrade I noticed failures after completing the 5.8.x upgrade. At first I tracked it to this - #27175, which then resulted in changing my
morphToparameters tonull, null, null, 'id'so ownerKey would be set properly.It still failed. It appeared that getting a 0 zero value back from
entity_type(entity morph) was passing theemptycheck in the wrong way no longer resulting in getting the morphed instance back.The comment above the code change even says "if value is null", so probably just a mistake.
Test
Never wrote a test for the DB area before. Hope it works out. Open for feedback.