Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Make DownCommand options available to prerendered view #35357

Merged
merged 3 commits into from Nov 26, 2020
Merged

[8.x] Make DownCommand options available to prerendered view #35357

merged 3 commits into from Nov 26, 2020

Conversation

npostman
Copy link
Contributor

Having the command options available to the pre-rendered view gives the possibility to, eg. see if the retry option was set, so you can add a meta-refresh tag to your view.

npostman and others added 3 commits November 24, 2020 14:00
Having the command instance available to the pre-rendered view gives the possibility to, eg. see if the retry option was set, so you can add a meta-refresh tag to your view.
As per Taylor's comment, now only passing along the Down command's options to the pre-rendering view, instead of the entire command instance.
@npostman npostman changed the title [8.x] Make DownCommand instance available to prerendered view [8.x] Make DownCommand options available to prerendered view Nov 25, 2020
@taylorotwell
Copy link
Member

I meant pass a specific variable like retryAfter => 'foo'...

@taylorotwell
Copy link
Member

Fixed it.

@taylorotwell taylorotwell merged commit a0b8812 into laravel:8.x Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants