Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Tests for route closures #35345

Merged
merged 2 commits into from Nov 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 29 additions & 0 deletions tests/Routing/RouteActionTest.php
@@ -0,0 +1,29 @@
<?php

namespace Illuminate\Tests\Routing;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Routing\RouteAction;
use Opis\Closure\SerializableClosure;
use PHPUnit\Framework\TestCase;

class RouteActionTest extends TestCase
{
public function test_it_can_detect_a_serialized_closure()
{
$action = ['uses' => serialize(new SerializableClosure(function (RouteActionUser $user) {
return $user;
}))];

$this->assertTrue(RouteAction::containsSerializedClosure($action));

$action = ['uses' => 'FooController@index'];

$this->assertFalse(RouteAction::containsSerializedClosure($action));
}
}

class RouteActionUser extends Model
{
//
}
29 changes: 29 additions & 0 deletions tests/Routing/RouteSignatureParametersTest.php
@@ -0,0 +1,29 @@
<?php

namespace Illuminate\Tests\Routing;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Routing\RouteSignatureParameters;
use Opis\Closure\SerializableClosure;
use PHPUnit\Framework\TestCase;
use ReflectionParameter;

class RouteSignatureParametersTest extends TestCase
{
public function test_it_can_extract_the_route_action_signature_parameters()
{
$action = ['uses' => serialize(new SerializableClosure($callable = function (SignatureParametersUser $user) {
return $user;
}))];

$parameters = RouteSignatureParameters::fromAction($action);

$this->assertContainsOnlyInstancesOf(ReflectionParameter::class, $parameters);
$this->assertSame('user', $parameters[0]->getName());
}
}

class SignatureParametersUser extends Model
{
//
}