[8.x] Add hasVerifiedEmail scope #35217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Nov 13, 2020
| * @param \Illuminate\Database\Eloquent\Builder $query | ||
| * @return \Illuminate\Database\Eloquent\Builder | ||
| */ | ||
| public function scopeHasVerifiedEmail(Builder $query); |
There was a problem hiding this comment.
This is a breaking change for any class that implements this interface.
There was a problem hiding this comment.
I also don't think this needs to be added to the interface since this is leaking Eloquent into the auth component.
There was a problem hiding this comment.
Yes, I was hesitating about that. I remove that from the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in #35215, this scope provides a more convinient way of scoping users with a verified email.
I know we have more flexibility here than in the case of
DatabaseNotification– so anyone can easily implement a custom scope – but in my experience, often this is one of the first things to do in a project so I thought it might be a good idea adding a scope by default.