[6.x] Adjust is_callable usage where needed for PHP 8 #34999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
GrahamCampbell
approved these changes
Oct 27, 2020
michaeldyrynda
added a commit
to thenpingme/thenpingme-laravel
that referenced
this pull request
Nov 17, 2020
@see laravel/framework#34999 The return string was changed from Closure to Callback in order to support PHP 8, which in turn broke how we were identifying closure tasks.
michaeldyrynda
added a commit
to thenpingme/thenpingme-laravel
that referenced
this pull request
Nov 17, 2020
Use Str to check for empty commands, which will account for the command being null or an empty string. Also add check for the closure summaryForDisplay output being one of either `Closure` or `Callback`, which was added to support PHP 8 @see laravel/framework#34999
michaeldyrynda
added a commit
to thenpingme/thenpingme-laravel
that referenced
this pull request
Nov 17, 2020
Use Str to check for empty commands, which will account for the command being null or an empty string. Also add check for the closure summaryForDisplay output being one of either `Closure` or `Callback`, which was added to support PHP 8 @see laravel/framework#34999
michaeldyrynda
added a commit
to thenpingme/thenpingme-laravel
that referenced
this pull request
Nov 17, 2020
Use Str to check for empty commands, which will account for the command being null or an empty string. Also add check for the closure summaryForDisplay output being one of either `Closure` or `Callback`, which was added to support PHP 8 @see laravel/framework#34999
michaeldyrynda
added a commit
to thenpingme/thenpingme-laravel
that referenced
this pull request
Nov 17, 2020
Use Str to check for empty commands, which will account for the command being null or an empty string. Also add check for the closure summaryForDisplay output being one of either `Closure` or `Callback`, which was added to support PHP 8 @see laravel/framework#34999
michaeldyrynda
added a commit
to thenpingme/thenpingme-laravel
that referenced
this pull request
Nov 17, 2020
Laravel changed the return of `getSummaryForDisplay` to be `Callback`, rather than `Closure`, in order to support PHP 8. @see laravel/framework#34999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.