Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add when() method to InteractsWithInput trait #33829

Merged
merged 4 commits into from Aug 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/Illuminate/Http/Concerns/InteractsWithInput.php
Expand Up @@ -430,4 +430,36 @@ protected function retrieveItem($source, $key, $default)

return $this->$source->get($key, $default);
}

/**
* Apply the callback if the request contains the given input item key.
*
* @param string $key
* @param callable $callback
* @return $this
*/
public function whenHas($key, callable $callback)
{
if ($this->has($key)) {
$callback(data_get($this->all(), $key));
}

return $this;
}

/**
* Apply the callback if the request contains a non-empty value for the given input item key.
*
* @param string $key
* @param callable $callback
* @return $this
*/
public function whenFilled($key, callable $callback)
{
if ($this->filled($key)) {
$callback(data_get($this->all(), $key));
}

return $this;
}
}
56 changes: 56 additions & 0 deletions tests/Http/HttpRequestTest.php
Expand Up @@ -300,6 +300,62 @@ public function testHasMethod()
$this->assertTrue($request->has('foo.baz'));
}

public function testWhenHasMethod()
{
$request = Request::create('/', 'GET', ['name' => 'Taylor', 'age' => '', 'city' => null]);

$name = $age = $city = $foo = false;

$request->whenHas('name', function ($value) use (&$name) {
$name = $value;
});

$request->whenHas('age', function ($value) use (&$age) {
$age = $value;
});

$request->whenHas('city', function ($value) use (&$city) {
$city = $value;
});

$request->whenHas('foo', function () use (&$foo) {
$foo = 'test';
});

$this->assertSame('Taylor', $name);
$this->assertSame('', $age);
$this->assertNull($city);
$this->assertFalse($foo);
}

public function testWhenFilledMethod()
{
$request = Request::create('/', 'GET', ['name' => 'Taylor', 'age' => '', 'city' => null]);

$name = $age = $city = $foo = false;

$request->whenFilled('name', function ($value) use (&$name) {
$name = $value;
});

$request->whenFilled('age', function ($value) use (&$age) {
$age = 'test';
});

$request->whenFilled('city', function ($value) use (&$city) {
$city = 'test';
});

$request->whenFilled('foo', function () use (&$foo) {
$foo = 'test';
});

$this->assertSame('Taylor', $name);
$this->assertFalse($age);
$this->assertFalse($city);
$this->assertFalse($foo);
}

public function testMissingMethod()
{
$request = Request::create('/', 'GET', ['name' => 'Taylor', 'age' => '', 'city' => null]);
Expand Down