[7.x] Fix Http::withCookies()

[SjorsO]

Currently, Http::withCookies() has an array typehint. If you give this method an array, it will throw this error: cookies must be an instance of GuzzleHttp\Cookie\CookieJarInterface

For reference, Zttp's withCookies method doesn't have a typehint.

Fixes #31750

[SjorsO]

The CI fails because --prefer-lowest installs Guzzle 6.3.0, which contains a bug that was fixed in 6.3.1: guzzle/guzzle#1999

[driesvints]

@SjorsO it only fails with this PR so we'd have to update the minimum version in this pr.

[SjorsO]

@SjorsO it only fails with this PR so we'd have to update the minimum version in this pr.

I'm not very familiar with version constraints, would changing "guzzlehttp/guzzle": "^6.3|^7.0", to "guzzlehttp/guzzle": "^6.3.1|^7.0", fix it?

[GrahamCampbell]

I'm not very familiar with version constraints, would changing "guzzlehttp/guzzle": "^6.3|^7.0", to "guzzlehttp/guzzle": "^6.3.1|^7.0", fix it?

Yes.

[GrahamCampbell]

Please update the suggest blocks too (in all composer.json files).

[SjorsO]

Please update the suggest blocks too (in all composer.json files).

I've updated the suggest block for the HTTP client.

I haven't updated the Console and Mail suggest blocks, because technically they would work with ^6.3.0. Should I update them to ^6.3.1 too?

[GrahamCampbell]

Please update all the suggest blocks, so the framework suggests the same version, across all the components.

[SjorsO]

Please update all the suggest blocks, so the framework suggests the same version, across all the components.

I've bumped all the ones I could find. Thanks for your help!

[GrahamCampbell]

Looks good now. 👍

[taylorotwell]

Uh, I don't want people to have to use a "CookieJar" - I just want to be able to pass an array.

[SjorsO]

@taylorotwell If you give this method an array Guzzle will throw an exception. Which means that with the current type-hint, this method is unusable.

ZTTP uses this method to re-use cookies between requests. $response->cookies() returns a CookieJar.

[gocanto]

@SjorsO you might want to accept the array as an argument and build the jar within the given method. :)

ref: https://github.com/guzzle/guzzle/blob/master/src/Cookie/CookieJar.php#L25

[SjorsO]

@SjorsO you might want to accept the array as an argument and build the jar within the given method. :)

ref: https://github.com/guzzle/guzzle/blob/master/src/Cookie/CookieJar.php#L25

I thought about using CookieJar::fromArray($array, $domain), but you don't have the $domain when this method is called, so it gets kind of tricky.

[driesvints]

Taylor pushed a new commit for this: 36d783c