[6.x] Optimize Service Provider registration

[Miguel-Serejo]

As per the discussion in #30952 and according to my tests, strpos is considerably faster than calling startsWith for short haystacks. This function is called for every provider on boot.
A default laravel installation will load 25 service providers.

I adapted the benchmark to test checking the default laravel packages. Benchmark code and results here: https://gist.github.com/36864/4bc70175ad0bb60b3261d1100f249cf5

Class names are unlikely to be longer than 100 characters, so this change should not have a negative impact.

According to the same benchmarks, a direct substring comparison would also be faster than the current implementation, but slower than strpos for strings

Sample result, over 1000000 iterations, checking if the provider class name starts with Illuminate\:

Provider: Illuminate\Foundation\Providers\ConsoleSupportServiceProvider
Array
(
    [strpos] => 0.077999114990234
    [substr] => 0.13390588760376
    [startswith] => 0.28392887115479
)

[yaayes]

Huge difference according to your benchmarks, thank you!
Nobody says no to performance. I wish this get merged (I haven't reviewed the code)

[GrahamCampbell]

Do you actually see a difference, compared to running the entire app though?

[Miguel-Serejo]

Well, no. We are clearly in micro-optimization territory here.

But I don't see a reason for the framework to use Str::startsWith when it is known that the needle is not an array, and the length of the haystack is also probably not much greater than 100 characters.

Further tests showed substr_compare to be even faster in "real use case" benchmarks but slower in more generic benchmarks. Further testing would be needed.

[GrahamCampbell]

I just feel this kind of micro-optimization is too far. The overhead of creating the collection and using the parturition method is probably more than the speedup you get from this change.

[dmitryuk]

Cheaters )