Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Implement better email validation support #29589

Merged
merged 2 commits into from
Aug 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 43 additions & 0 deletions src/Illuminate/Validation/Concerns/FilterEmailValidation.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php

namespace Illuminate\Validation\Concerns;

use Egulias\EmailValidator\EmailLexer;
use Egulias\EmailValidator\Warning\Warning;
use Egulias\EmailValidator\Exception\InvalidEmail;
use Egulias\EmailValidator\Validation\EmailValidation;

class FilterEmailValidation implements EmailValidation
{
/**
* Returns true if the given email is valid.
*
* @param string $email The email you want to validate.
* @param EmailLexer $emailLexer The email lexer.
*
* @return bool
*/
public function isValid($email, EmailLexer $emailLexer)
{
return filter_var($email, FILTER_VALIDATE_EMAIL) !== false;
}

/**
* Returns the validation error.
*
* @return InvalidEmail|null
*/
public function getError()
{
}

/**
* Returns the validation warnings.
*
* @return Warning[]
*/
public function getWarnings()
{
return [];
}
}
29 changes: 26 additions & 3 deletions src/Illuminate/Validation/Concerns/ValidatesAttributes.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
use Symfony\Component\HttpFoundation\File\File;
use Egulias\EmailValidator\Validation\RFCValidation;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Egulias\EmailValidator\Validation\DNSCheckValidation;
use Egulias\EmailValidator\Validation\SpoofCheckValidation;
use Egulias\EmailValidator\Validation\NoRFCWarningsValidation;
use Egulias\EmailValidator\Validation\MultipleValidationWithAnd;

trait ValidatesAttributes
{
Expand Down Expand Up @@ -621,16 +625,35 @@ protected function extractDistinctValues($attribute)
* Validate that an attribute is a valid e-mail address.
*
* @param string $attribute
* @param mixed $value
* @param mixed $value
* @param array $parameters
* @return bool
*/
public function validateEmail($attribute, $value)
public function validateEmail($attribute, $value, $parameters)
{
if (! is_string($value) && ! (is_object($value) && method_exists($value, '__toString'))) {
return false;
}

return (new EmailValidator)->isValid($value, new RFCValidation);
$validations = collect($parameters)
->unique()
->map(function ($validation) {
if ($validation === 'rfc') {
return new RFCValidation();
} elseif ($validation === 'strict') {
return new NoRFCWarningsValidation();
} elseif ($validation === 'dns') {
return new DNSCheckValidation();
} elseif ($validation === 'spoof') {
return new SpoofCheckValidation();
} elseif ($validation === 'filter') {
return new FilterEmailValidation();
}
})
->values()
->all() ?: [new RFCValidation()];

return (new EmailValidator)->isValid($value, new MultipleValidationWithAnd($validations));
}

/**
Expand Down
12 changes: 12 additions & 0 deletions tests/Validation/ValidationValidatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2138,6 +2138,18 @@ public function testValidateEmailWithInternationalCharacters()
$this->assertTrue($v->passes());
}

public function testValidateEmailWithStrictCheck()
{
$v = new Validator($this->getIlluminateArrayTranslator(), ['x' => 'foo@bar '], ['x' => 'email:strict']);
$this->assertFalse($v->passes());
}

public function testValidateEmailWithFilterCheck()
{
$v = new Validator($this->getIlluminateArrayTranslator(), ['x' => 'foo@bar'], ['x' => 'email:filter']);
$this->assertFalse($v->passes());
}

/**
* @dataProvider validUrls
*/
Expand Down