[5.7] Fix Postgres grammar when using union queries #27589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Feb 20, 2019
| @@ -873,7 +901,7 @@ public function testUnionAggregate() | |||
| $builder->getProcessor()->shouldReceive('processSelect')->once(); | |||
| $builder->from('posts')->select('id')->union($this->getMySqlBuilder()->from('videos')->select('id'))->count(); | |||
|
|
|||
| $expected = 'select count(*) as aggregate from (select * from "posts" union select * from "videos") as "temp_table"'; | |||
| $expected = 'select count(*) as aggregate from ((select * from "posts") union (select * from "videos")) as "temp_table"'; | |||
There was a problem hiding this comment.
This PR now adds them always, even if not necessary. But I guess this is fine? 🤷♀️
There was a problem hiding this comment.
Yes, just only a select clause is not necessary, but if a LIMIT or GROUP BY clause is added, parentheses are necessary in Postgres. I guess that this behavior is not a problem. 😄
|
PS: can confirm the problem; as soon as |
This was referenced Feb 21, 2019
GrahamCampbell
changed the title
|
Any chance this can get merged into lumen as well? Having same issue and lumen 5.7 doesn't produce the parentheses. |
|
@jnguyen32 I don't see how this affects lumen? Lumen just uses the DB component from Laravel. It doesn't has custom query builder functionality. |
NateWr
added a commit
to NateWr/pkp-lib
that referenced
this pull request
Apr 3, 2019
Laravel's QueryBuilder doesn't do unions in postgres until v5.7. Since we run v5.5, we need to manually piece the union sql string together. See: laravel/framework#27589
NateWr
added a commit
to NateWr/pkp-lib
that referenced
this pull request
Apr 8, 2019
Laravel's QueryBuilder doesn't do unions in postgres until v5.7. Since we run v5.5, we need to manually piece the union sql string together. See: laravel/framework#27589
NateWr
added a commit
to NateWr/pkp-lib
that referenced
this pull request
Apr 17, 2019
Laravel's QueryBuilder doesn't do unions in postgres until v5.7. Since we run v5.5, we need to manually piece the union sql string together. See: laravel/framework#27589
NateWr
added a commit
to NateWr/pkp-lib
that referenced
this pull request
Apr 29, 2019
Laravel's QueryBuilder doesn't do unions in postgres until v5.7. Since we run v5.5, we need to manually piece the union sql string together. See: laravel/framework#27589
NateWr
added a commit
to NateWr/pkp-lib
that referenced
this pull request
Apr 30, 2019
Laravel's QueryBuilder doesn't do unions in postgres until v5.7. Since we run v5.5, we need to manually piece the union sql string together. See: laravel/framework#27589
NateWr
added a commit
to NateWr/pkp-lib
that referenced
this pull request
May 1, 2019
Laravel's QueryBuilder doesn't do unions in postgres until v5.7. Since we run v5.5, we need to manually piece the union sql string together. See: laravel/framework#27589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Postgres grammar creates SQL invalid when query has
unionorunion all, usinglimitand/oroffsetclauses in its subqueries.Postgres syntax needs that subquery is between parentheses:
Wrong
Correct
This approach is based in PR #17890.