fix conflicts

laravel · Aug 27, 2020 · fad3e5f · fad3e5f
2 parents aa4e269 + cd1ab41
commit fad3e5f
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/src/Illuminate/Database/Eloquent/Builder.php b/src/Illuminate/Database/Eloquent/Builder.php
@@ -193,7 +193,7 @@ public function whereKey($id)
             return $this;
         }
 
-        if ($this->model->getKeyType() === 'string') {
+        if ($id !== null && $this->model->getKeyType() === 'string') {
             $id = (string) $id;
         }
 
@@ -214,7 +214,7 @@ public function whereKeyNot($id)
             return $this;
         }
 
-        if ($this->model->getKeyType() === 'string') {
+        if ($id !== null && $this->model->getKeyType() === 'string') {
             $id = (string) $id;
         }
 

diff --git a/src/Illuminate/Foundation/Application.php b/src/Illuminate/Foundation/Application.php
@@ -33,7 +33,7 @@ class Application extends Container implements ApplicationContract, CachesConfig
      *
      * @var string
      */
-    const VERSION = '7.26.0';
+    const VERSION = '7.26.1';
 
     /**
      * The base path for the Laravel installation.

diff --git a/tests/Database/DatabaseEloquentBuilderTest.php b/tests/Database/DatabaseEloquentBuilderTest.php
@@ -1063,6 +1063,19 @@ public function testWhereKeyMethodWithStringZero()
         $builder->whereKey($int);
     }
 
+    public function testWhereKeyMethodWithStringNull()
+    {
+        $model = new EloquentBuilderTestStubStringPrimaryKey();
+        $builder = $this->getBuilder()->setModel($model);
+        $keyName = $model->getQualifiedKeyName();
+
+        $builder->getQuery()->shouldReceive('where')->once()->with($keyName, '=', m::on(function ($argument) {
+            return $argument === null;
+        }));
+
+        $builder->whereKey(null);
+    }
+
     public function testWhereKeyMethodWithArray()
     {
         $model = $this->getMockModel();
@@ -1102,6 +1115,19 @@ public function testWhereKeyNotMethodWithStringZero()
         $builder->whereKeyNot($int);
     }
 
+    public function testWhereKeyNotMethodWithStringNull()
+    {
+        $model = new EloquentBuilderTestStubStringPrimaryKey();
+        $builder = $this->getBuilder()->setModel($model);
+        $keyName = $model->getQualifiedKeyName();
+
+        $builder->getQuery()->shouldReceive('where')->once()->with($keyName, '!=', m::on(function ($argument) {
+            return $argument === null;
+        }));
+
+        $builder->whereKeyNot(null);
+    }
+
     public function testWhereKeyNotMethodWithInt()
     {
         $model = $this->getMockModel();