Skip to content

Commit

Permalink
[8.x] Test Improvements (#39808)
Browse files Browse the repository at this point in the history
* Test Improvements

Avoid running `DatabaseMigrations` when driver !== mysql.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

* wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
  • Loading branch information
crynobone committed Nov 29, 2021
1 parent 78637dc commit f47d18f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions tests/Integration/Database/MySql/MySqlTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@

abstract class MySqlTestCase extends DatabaseTestCase
{
protected function setUp(): void
protected function defineDatabaseMigrations()
{
parent::setUp();

if ($this->driver !== 'mysql') {
$this->markTestSkipped('Test requires a MySQL connection.');
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Integration/Database/SchemaBuilderTest.php
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<?php

namespace Illuminate\Tests\Integration\Database\SchemaTest;
namespace Illuminate\Tests\Integration\Database;

use Doctrine\DBAL\Types\Type;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Schema\Grammars\SQLiteGrammar;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
use Illuminate\Tests\Integration\Database\DatabaseTestCase;
use Illuminate\Tests\Integration\Database\Fixtures\TinyInteger;

class SchemaBuilderTest extends DatabaseTestCase
Expand Down

0 comments on commit f47d18f

Please sign in to comment.