Skip to content

Commit

Permalink
[8.x] Tests for route closures (#35345)
Browse files Browse the repository at this point in the history
* Test RouteAction

* Add RouteSignatureParameters test
  • Loading branch information
driesvints committed Nov 24, 2020
1 parent 10ad064 commit af49b8e
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 0 deletions.
29 changes: 29 additions & 0 deletions tests/Routing/RouteActionTest.php
@@ -0,0 +1,29 @@
<?php

namespace Illuminate\Tests\Routing;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Routing\RouteAction;
use Opis\Closure\SerializableClosure;
use PHPUnit\Framework\TestCase;

class RouteActionTest extends TestCase
{
public function test_it_can_detect_a_serialized_closure()
{
$action = ['uses' => serialize(new SerializableClosure(function (RouteActionUser $user) {
return $user;
}))];

$this->assertTrue(RouteAction::containsSerializedClosure($action));

$action = ['uses' => 'FooController@index'];

$this->assertFalse(RouteAction::containsSerializedClosure($action));
}
}

class RouteActionUser extends Model
{
//
}
29 changes: 29 additions & 0 deletions tests/Routing/RouteSignatureParametersTest.php
@@ -0,0 +1,29 @@
<?php

namespace Illuminate\Tests\Routing;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Routing\RouteSignatureParameters;
use Opis\Closure\SerializableClosure;
use PHPUnit\Framework\TestCase;
use ReflectionParameter;

class RouteSignatureParametersTest extends TestCase
{
public function test_it_can_extract_the_route_action_signature_parameters()
{
$action = ['uses' => serialize(new SerializableClosure($callable = function (SignatureParametersUser $user) {
return $user;
}))];

$parameters = RouteSignatureParameters::fromAction($action);

$this->assertContainsOnlyInstancesOf(ReflectionParameter::class, $parameters);
$this->assertSame('user', $parameters[0]->getName());
}
}

class SignatureParametersUser extends Model
{
//
}

0 comments on commit af49b8e

Please sign in to comment.