Improves testing

laravel · Apr 13, 2021 · a1fc2aa · a1fc2aa
1 parent 15bea14
commit a1fc2aa
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/tests/Validation/ValidationNotPwnedVerifierTest.php b/tests/Validation/ValidationNotPwnedVerifierTest.php
@@ -39,16 +39,20 @@ public function testApiResponseGoesWrong()
 
         $httpFactory
             ->shouldReceive('withHeaders')
+            ->once()
             ->with(['Add-Padding' => true])
-            ->andThrow($httpFactory);
+            ->andReturn($httpFactory);
 
         $httpFactory->shouldReceive('get')
+            ->once()
             ->andReturn($response);
 
         $response->shouldReceive('successful')
+            ->once()
             ->andReturn(true);
 
         $response->shouldReceive('body')
+            ->once()
             ->andReturn('');
 
         $verifier = new NotPwnedVerifier($httpFactory);
@@ -63,13 +67,16 @@ public function testApiGoesDown()
 
         $httpFactory
             ->shouldReceive('withHeaders')
+            ->once()
             ->with(['Add-Padding' => true])
-            ->andThrow($httpFactory);
+            ->andReturn($httpFactory);
 
         $httpFactory->shouldReceive('get')
+            ->once()
             ->andReturn($response);
 
         $response->shouldReceive('successful')
+            ->once()
             ->andReturn(false);
 
         $verifier = new NotPwnedVerifier($httpFactory);
@@ -92,11 +99,13 @@ public function testDnsDown()
 
         $httpFactory
             ->shouldReceive('withHeaders')
+            ->once()
             ->with(['Add-Padding' => true])
-            ->andThrow($httpFactory);
+            ->andReturn($httpFactory);
 
         $httpFactory
             ->shouldReceive('get')
+            ->once()
             ->andThrow($exception);
 
         $verifier = new NotPwnedVerifier($httpFactory);