Remove throw in BoundMethod (#34970)

laravel · Oct 26, 2020 · 826a90f · 826a90f
1 parent b1555ed
commit 826a90f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/Illuminate/Container/BoundMethod.php b/src/Illuminate/Container/BoundMethod.php
@@ -3,7 +3,6 @@
 namespace Illuminate\Container;
 
 use Closure;
-use Illuminate\Contracts\Container\BindingResolutionException;
 use InvalidArgumentException;
 use ReflectionFunction;
 use ReflectionMethod;
@@ -174,10 +173,6 @@ protected static function addDependencyForCallParameter($container, $parameter,
             }
         } elseif ($parameter->isDefaultValueAvailable()) {
             $dependencies[] = $parameter->getDefaultValue();
-        } elseif (! $parameter->isOptional() && ! array_key_exists($paramName, $parameters)) {
-            $message = "Unable to resolve dependency [{$parameter}] in class {$parameter->getDeclaringClass()->getName()}";
-
-            throw new BindingResolutionException($message);
         }
     }
 

diff --git a/tests/Container/ContainerCallTest.php b/tests/Container/ContainerCallTest.php
@@ -91,6 +91,13 @@ public function testCallWithBoundMethod()
         $this->assertSame('taylor', $result[1]);
     }
 
+    public function testCallWithUnnamedParameters()
+    {
+        $container = new Container;
+        $result = $container->call([new ContainerTestCallStub, 'unresolvable'], ['foo', 'bar']);
+        $this->assertEquals(['foo', 'bar'], $result);
+    }
+
     public function testBindMethodAcceptsAnArray()
     {
         $container = new Container;