Allow nested errors in json assertion (#33989)

laravel · Aug 24, 2020 · 7161c83 · 7161c83
1 parent 21520ee
commit 7161c83
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Illuminate/Testing/TestResponse.php b/src/Illuminate/Testing/TestResponse.php
@@ -729,7 +729,7 @@ public function assertJsonValidationErrors($errors, $responseKey = 'errors')
 
         PHPUnit::assertNotEmpty($errors, 'No validation errors were provided.');
 
-        $jsonErrors = $this->json()[$responseKey] ?? [];
+        $jsonErrors = Arr::get($this->json(), $responseKey) ?? [];
 
         $errorMessage = $jsonErrors
                 ? 'Response has the following JSON validation errors:'.

diff --git a/tests/Testing/TestResponseTest.php b/tests/Testing/TestResponseTest.php
@@ -611,6 +611,20 @@ public function testAssertJsonValidationErrorsCustomErrorsName()
         $testResponse->assertJsonValidationErrors('foo', 'data');
     }
 
+    public function testAssertJsonValidationErrorsCustomNestedErrorsName()
+    {
+        $data = [
+            'status' => 'ok',
+            'data' => ['errors' => ['foo' => 'oops']],
+        ];
+
+        $testResponse = TestResponse::fromBaseResponse(
+            (new Response)->setContent(json_encode($data))
+        );
+
+        $testResponse->assertJsonValidationErrors('foo', 'data.errors');
+    }
+
     public function testAssertJsonValidationErrorsCanFail()
     {
         $this->expectException(AssertionFailedError::class);