[8.x] Fix Http::withBody() not being sent (#37057)

* Send pending body with the request * StyleCI
laravel · Apr 20, 2021 · 57c283c · 57c283c
1 parent 856cdba
commit 57c283c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/Illuminate/Http/Client/PendingRequest.php b/src/Illuminate/Http/Client/PendingRequest.php
@@ -642,6 +642,8 @@ public function send(string $method, string $url, array $options = [])
                     $options[$this->bodyFormat], $this->pendingFiles
                 );
             }
+        } else {
+            $options[$this->bodyFormat] = $this->pendingBody;
         }
 
         [$this->pendingBody, $this->pendingFiles] = [null, []];

diff --git a/tests/Http/HttpClientTest.php b/tests/Http/HttpClientTest.php
@@ -76,6 +76,21 @@ public function testResponseCanBeReturnedAsCollection()
         $this->assertEquals(collect(), $response->collect('missing_key'));
     }
 
+    public function testSendRequestBody()
+    {
+        $body = '{"test":"phpunit"}';
+
+        $fakeRequest = function (Request $request) use ($body) {
+            self::assertSame($body, $request->body());
+
+            return ['my' => 'response'];
+        };
+
+        $this->factory->fake($fakeRequest);
+
+        $this->factory->withBody($body, 'application/json')->send('get', 'http://foo.com/api');
+    }
+
     public function testUrlsCanBeStubbedByPath()
     {
         $this->factory->fake([