Skip to content

Commit

Permalink
[8.x] Fix database tests (#44831)
Browse files Browse the repository at this point in the history 
(cherry picked from commit 26ed162)

Co-authored-by: Dries Vints <dries@vints.io>
  • Loading branch information
@bytestream @driesvints
bytestream and driesvints committed Nov 3, 2022
1 parent 5ed7945 commit 36c2292
Showing 1 changed file with 131 additions and 49 deletions.
180 changes: 131 additions & 49 deletions tests/Database/DatabaseSchemaBlueprintIntegrationTest.php
View file
Expand Up @@ -84,6 +84,18 @@ public function testRenamingAndChangingColumnsWork()
'INSERT INTO users (first_name, age) SELECT name, age FROM __temp__users',
'DROP TABLE __temp__users',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name, age FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) NOT NULL COLLATE "BINARY", age INTEGER NOT NULL)',
'INSERT INTO users (name, age) SELECT name, age FROM __temp__users',
'DROP TABLE __temp__users',
'CREATE TEMPORARY TABLE __temp__users AS SELECT name, age FROM users',
'DROP TABLE users',
'CREATE TABLE users (first_name VARCHAR(255) NOT NULL, age VARCHAR(255) NOT NULL COLLATE "BINARY")',
'INSERT INTO users (first_name, age) SELECT name, age FROM __temp__users',
'DROP TABLE __temp__users',
],
];

$this->assertTrue(in_array($queries, $expected));
Expand All @@ -104,26 +116,46 @@ public function testChangingColumnWithCollationWorks()
});

$queries = $blueprint->toSql($this->db->connection(), new SQLiteGrammar);
$queries2 = $blueprint2->toSql($this->db->connection(), new SQLiteGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE RTRIM)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE RTRIM)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE "RTRIM")',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
];

$expected2 = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE NOCASE)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
$this->assertContains($queries, $expected);

$queries = $blueprint2->toSql($this->db->connection(), new SQLiteGrammar);

$expected = [
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE NOCASE)',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users',
'DROP TABLE users',
'CREATE TABLE users (age INTEGER NOT NULL COLLATE "NOCASE")',
'INSERT INTO users (age) SELECT age FROM __temp__users',
'DROP TABLE __temp__users',
],
];

$this->assertEquals($expected, $queries);
$this->assertEquals($expected2, $queries2);
$this->assertContains($queries, $expected);
}

public function testRenameIndexWorks()
Expand Down Expand Up @@ -188,15 +220,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintMySql->toSql($this->db->connection(), new MySqlGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `users_name_unique`(`name`)',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `users_name_unique`(`name`)',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `users_name_unique`(`name`)',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintPostgres = new Blueprint('users', function ($table) {
$table->string('name')->nullable()->unique()->change();
Expand All @@ -205,15 +247,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintPostgres->toSql($this->db->connection(), new PostgresGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table "users" add constraint "users_name_unique" unique ("name")',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table "users" add constraint "users_name_unique" unique ("name")',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table "users" add constraint "users_name_unique" unique ("name")',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintSQLite = new Blueprint('users', function ($table) {
$table->string('name')->nullable()->unique()->change();
Expand All @@ -222,15 +274,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintSQLite->toSql($this->db->connection(), new SQLiteGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintSqlServer = new Blueprint('users', function ($table) {
$table->string('name')->nullable()->unique()->change();
Expand All @@ -239,15 +301,25 @@ public function testAddUniqueIndexWithoutNameWorks()
$queries = $blueprintSqlServer->toSql($this->db->connection(), new SqlServerGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'create unique index "users_name_unique" on "users" ("name")',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);
}

public function testAddUniqueIndexWithNameWorks()
Expand All @@ -263,15 +335,25 @@ public function testAddUniqueIndexWithNameWorks()
$queries = $blueprintMySql->toSql($this->db->connection(), new MySqlGrammar);

$expected = [
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `index1`(`name`)',
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE BINARY)',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `index1`(`name`)',
],
[
'CREATE TEMPORARY TABLE __temp__users AS SELECT name FROM users',
'DROP TABLE users',
'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")',
'INSERT INTO users (name) SELECT name FROM __temp__users',
'DROP TABLE __temp__users',
'alter table `users` add unique `index1`(`name`)',
],
];

$this->assertEquals($expected, $queries);
$this->assertContains($queries, $expected);

$blueprintPostgres = new Blueprint('users', function ($table) {
$table->unsignedInteger('name')->nullable()->unique('index1')->change();
Expand Down

0 comments on commit 36c2292

Please sign in to comment.