Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #497

Merged
merged 3 commits into from Jan 15, 2024
Merged

Conversation

browner12
Copy link
Contributor

  • align is an obsolete HTML5 attribute. replace with CSS styling.
  • add an alt attribute to the <img> tag for accessibility.
  • remove redundant </img> closing tag.
  • the <center> tag is not supported in HTML5. replace with CSS styling.
  • the <bold> tag does not exist. The <h4> receives bolding anyway, so the whole line is bolded.

- `align` is an obsolete HTML5 attribute. replace with CSS styling.
- add an `alt` attribute to the `<img>` tag for accessibility.
- remove redundant `</img>` closing tag.
- the `<center>` tag is not supported in HTML5. replace with CSS styling.
- the `<bold>` tag does not exist. The `<h4>` receives bolding anyway, so the whole line is bolded.
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@owenvoke
Copy link
Member

The style attribute (and CSS in general) does not work on GitHub, which is why the align tag is used. This is not ideal (and I agree that it should be removed in future), but it works. 🤷🏻

- remove "community project" line per request
- revert `align="center"` per request, as apparently style attributes don't work in GitHub.
@browner12
Copy link
Contributor Author

All requested changes should be made. LMK if you'd like anything else.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@owenvoke owenvoke merged commit 09d8202 into laravel-zero:master Jan 15, 2024
8 checks passed
@browner12 browner12 deleted the AB-minor-html-fixes branch January 15, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants