Skip to content

Commit

Permalink
Merge pull request #485 from owenvoke/feature/php-8.3
Browse files Browse the repository at this point in the history
ci: run tests against PHP 8.3
  • Loading branch information
owenvoke committed Dec 11, 2023
2 parents 517dddb + 297dda5 commit 23699dd
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
php: ['8.1', '8.2']
php: ['8.1', '8.2', '8.3']
dependency-version: [lowest, highest]

name: PHP ${{ matrix.php }} - ${{ matrix.os }} - ${{ matrix.dependency-version }}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -60,7 +60,7 @@
"illuminate/view": "^10.28",
"laminas/laminas-text": "^2.10",
"laravel-zero/phar-updater": "^1.4",
"laravel/pint": "^1.13.3",
"laravel/pint": "^1.13.7",
"nunomaduro/laravel-console-dusk": "^1.11",
"nunomaduro/laravel-console-menu": "^3.4",
"nunomaduro/termwind": "^1.15.1",
Expand Down
4 changes: 2 additions & 2 deletions src/Exceptions/ConsoleException.php
Expand Up @@ -40,9 +40,9 @@ final class ConsoleException extends Exception implements ConsoleExceptionContra
*/
public function __construct(
int $exitCode,
string $message = null,
?string $message = null,
array $headers = [],
Exception $previous = null,
?Exception $previous = null,
?int $code = 0
) {
$this->exitCode = $exitCode;
Expand Down
Expand Up @@ -29,7 +29,7 @@ final class CommandRecorderRepository
/**
* CommandRecorderRepository constructor.
*/
public function __construct(Collection $storage = null)
public function __construct(?Collection $storage = null)
{
$this->storage = $storage ?? collect();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Providers/Composer/Composer.php
Expand Up @@ -72,7 +72,7 @@ public function createProject(string $skeleton, string $projectName, array $opti
/**
* Runs the provided command on the provided folder.
*/
private function run(string $cmd, string $cwd = null): bool
private function run(string $cmd, ?string $cwd = null): bool
{
$process = Process::fromShellCommandline($cmd, $cwd);

Expand Down

0 comments on commit 23699dd

Please sign in to comment.