Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the Foundation to v8.19.0 #47

Merged
merged 1 commit into from Dec 16, 2020

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented Dec 16, 2020

I noticed that Laravel core now includes a schedule:list command. Currently in the framework, we have a schedule-list component. Not sure how we want to handle this situation. 馃

@nunomaduro (and @billysmithers as you opened the original PR with this component), what are your thoughts on this? It looks like the package has more functionality than the one included in core.

@billysmithers
Copy link

@owenvoke Thanks for considering me in the discussion. I have no issue in moving to the Laravel core command, as it is then something maintained at that level. However am happy to see what other people think especially if it means losing functionality that users of the Zero framework rely on.

@nunomaduro
Copy link
Member

The "schedule-list" component is an opt-in? If yes, maybe we leave it?

@billysmithers
Copy link

@nunomaduro As far as I know it is an opt-in. @owenvoke would there be conflicts with the core command if we left the component in place, I think they share the same signature?

@nunomaduro
Copy link
Member

I think the component will override the existing one. So it's fine.

@owenvoke
Copy link
Member Author

Ah, if it overrides the one from core, then that's fine. I'll have a quick test to double check and then release this. 馃憣馃徎 Cheers both of you for your input!

@owenvoke
Copy link
Member Author

Ah, just remembered it doesn't matter as the command isn't registered in Laravel Zero's framework. 馃憤馃徎 Merging.

@owenvoke owenvoke merged commit f56ea49 into laravel-zero:main Dec 16, 2020
@owenvoke owenvoke deleted the feature/8.x-update branch December 16, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants