Fix breaking change with twitter dependency bump #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophrumpel
merged commit 30375f8
into
laravel-notification-channels:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently #103 was merged without it being noticed that there's a major breaking change in
abraham/twitteroauthv7: abraham/twitteroauth#1220Because of this, all of our Twitter notifications started to fail. I can't see any major things really needed for v7: abraham/twitteroauth@6.2.0...main so I propose that we just remove v7 from the constraints for now. This package will need to do a new major release to adopt v7 of
abraham/twitteroauthand subsequently drop v5 and v6 (which I added here).Would appreciate a quick merge and tag if possible 馃檹