Switch to vue-style-loader when using mix.vue() #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @thecrypticace, I think you should keep |
|
Yep, saw that this morning. Pretty sure that's why the test fails. I'll keep this around to have it ready when vue-style-loader updates. |
emmm I don't think they will update, that PR is hanging from Aug |
JeffreyWay
force-pushed
the
master
branch
2 times, most recently
from
ebd1778
to
9f10e00
Compare
|
vue-style-loader (v4.1.3) was updated to support css-loader 4+, can we now try to implement the above? |
thecrypticace
force-pushed
the
feature/vue-style-loader
branch
from
51011cb
to
cbf8a38
Compare
|
Hi @thecrypticace the build test failed again, but I don't think is related to |
thecrypticace
force-pushed
the
feature/vue-style-loader
branch
from
cbf8a38
to
56eac79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2725