Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fix regarding Vue dependencies #2368

Closed
wants to merge 2 commits into from
Closed

Some fix regarding Vue dependencies #2368

wants to merge 2 commits into from

Conversation

nmfzone
Copy link

@nmfzone nmfzone commented Apr 3, 2020

  • Javascript components: Only use Vue dependencies when vue is installed
  • Vue components: Make sure vue added as dependencies

@paullaffitte
Copy link
Contributor

Looks like a duplicate of #2339, am I right?

@JeffreyWay
Copy link
Collaborator

Sorry for the delay, but we’re handling this in a different way for upcoming release.

@JeffreyWay JeffreyWay closed this Sep 28, 2020
@nmfzone nmfzone deleted the patch-1 branch January 23, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmfzone @paullaffitte @JeffreyWay