New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fs.mkdirSync instead of fs-extra.ensureDirSync #2107

Closed

blueberrystream wants to merge 1 commit into laravel-mix:master from blueberrystream:feature/use-node-fs-mkdir

blueberrystream commented May 17, 2019

node.js fs.mkdirSync can make directories recursively since 10.12.0
- node/CHANGELOG_V10.md at master · nodejs/node
- File System | Node.js v12.2.0 Documentation
fs-extra.mkdirp/mkdirs/ensureDir may be removed.
- Recursive mkdir coming to Node core · Issue #619 · jprichardson/node-fs-extra


          use fs.mkdirSync instead of fs-extra.ensureDirSync

6d8514d

Signed-off-by: KID the Euforia <kid0725+github@gmail.com>

Author

blueberrystream commented May 17, 2019 •

edited

I see .travis.yml
https://github.com/JeffreyWay/laravel-mix/blob/master/.travis.yml#L8-L13

laravel-mix supports node.js 8/9/10/11, but this PR requires node.js >= 10.12.0.
Therefore I will close this PR.

blueberrystream closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment