-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]New database factory system #526
base: 2.0
Are you sure you want to change the base?
Conversation
… Remove factory relationships.
Codecov Report
@@ Coverage Diff @@
## 1.8 #526 +/- ##
============================================
+ Coverage 54.49% 55.32% +0.82%
- Complexity 824 889 +65
============================================
Files 101 103 +2
Lines 2325 2500 +175
============================================
+ Hits 1267 1383 +116
- Misses 1058 1117 +59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ory system and laravel default
Looks good to me |
Assertions documentation
Please let me know if you have any questions or need any assistance from me. |
Any news regarding this? should be awesome to have this running.... |
Hey all, I'm new to laravel-doctrine but love having good testing utilities. Is there anything we can do to help move this along? |
Changes proposed in this pull request:
The new database factory system is added, it was copied from the Laravel Eloquent modern factories https://laravel.com/docs/9.x/database-testing
Everything except Factory relationships has been implemented and works for Doctrine.
The new system is object-oriented, easily extensible, doesn't use any magic files and supports IDE autocompletion.
Fixes #470
Changes to be done
Please let me know if this PR looks good, and I'll add documentation (actually copy-paste it from the Laravel).
The current implementation of database factories
While Laravel moved the old factory system into another package laravel/legacy-factories, we might leave it for backward compatibility as both systems can coexist without any problem.