fix: properly handle arguments for casts #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgaal
changed the title
szepeviktor
reviewed
Jan 24, 2023
szepeviktor
changed the title
|
@canvural Seems like CI fails because of a reason outside this PR. |
szepeviktor
force-pushed
the
patch-castables
branch
from
3164fca
to
ba16dd1
Compare
|
Now everything should be okay ✔️ |
szepeviktor
approved these changes
Jan 24, 2023
canvural
reviewed
Jan 25, 2023
canvural
approved these changes
Feb 2, 2023
|
Thank you! |
|
@canvural would it be possible to put out a new release that includes this fix? 🙏🏻 |
|
@rovansteen Here we go! 🚲 |
|
@szepeviktor thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1525.
Breaking changes