Improve handling of read types on custom model casts #1444
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a pretty annoying issue while using Larastan and model casts.
For example, when using the Laravel Money package, it has a custom cast class
\Cknow\Money\Casts\MoneyIntegerCast
.This casts
get
method returns a\Cknow\Money\Money
object, but Larastan only detected theMoneyIntegerCast
as the return type.This causes dozens of errors similar to:
To fix this issue, I have used reflection to determine the return type of the casts underlying
get
method, and (if it is defined), use that as the read type for the attribute.I am aware of this PR #1333, but I thought a smaller PR to fix this problem faster would be nice, until that one gets merged.