feat: unused views collector rule #1423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new rule that can find the unused views, using PHPStan's collector feature. It'll be an optional rule.
Some concerns
view('foo')
calls. And$this->markdown('foo')
in anyMailable
class. Are there more places that we can check?@extends('foo')
I'd say this is an edge case, and can be ignored by the user.Todos
View::make('foo')
and$viewFactory->make()
$this->view('foo')
inMailable
sHow to test it?
Run
composer require --dev nunomaduro/larastan:dev-unused-views
Then run your PHPStan analysis again.And report here if there are any false positives or errors that we can fix!