feat: handle native enum casts (#1494)

larastan · Jan 15, 2023 · 92cd4f5 · 92cd4f5
1 parent 6337254
commit 92cd4f5
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 0 deletions.
diff --git a/src/Properties/ModelCastHelper.php b/src/Properties/ModelCastHelper.php
@@ -60,6 +60,10 @@ public function getReadableType(string $cast, Type $originalType): Type
 
         $classReflection = $this->reflectionProvider->getClass($cast);
 
+        if ($classReflection->isEnum()) {
+            return new ObjectType($cast);
+        }
+
         if ($classReflection->isSubclassOf(Castable::class)) {
             $methodReflection = $classReflection->getNativeMethod('castUsing');
             $castUsingReturn = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
@@ -111,6 +115,10 @@ public function getWriteableType(string $cast, Type $originalType): Type
 
         $classReflection = $this->reflectionProvider->getClass($cast);
 
+        if ($classReflection->isEnum()) {
+            return new ObjectType($cast);
+        }
+
         if ($classReflection->isSubclassOf(Castable::class)) {
             $methodReflection = $classReflection->getNativeMethod('castUsing');
             $castUsingReturn = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();

diff --git a/tests/Application/app/Casts/BackedEnumeration.php b/tests/Application/app/Casts/BackedEnumeration.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace App\Casts;
+
+enum BackedEnumeration : string
+{
+}
diff --git a/tests/Application/app/Casts/BasicEnumeration.php b/tests/Application/app/Casts/BasicEnumeration.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace App\Casts;
+
+enum BasicEnumeration
+{
+}
diff --git a/tests/Application/app/User.php b/tests/Application/app/User.php
@@ -2,6 +2,8 @@
 
 namespace App;
 
+use App\Casts\BackedEnumeration;
+use App\Casts\BasicEnumeration;
 use App\Casts\Favorites;
 use App\Casts\Hash;
 use function get_class;
@@ -54,6 +56,8 @@ class User extends Authenticatable
         'properties' => AsCollection::class,
         'favorites' => Favorites::class,
         'secret' => Hash::class.':sha256',
+        'basic_enum' => BasicEnumeration::class,
+        'backed_enum' => BackedEnumeration::class,
 
         'int' => 'int',
         'integer' => 'integer',

diff --git a/tests/Application/database/migrations/2020_01_30_000000_create_users_table.php b/tests/Application/database/migrations/2020_01_30_000000_create_users_table.php
@@ -32,6 +32,8 @@ public function up(): void
             $table->unknownColumnType('unknown_column');
             $table->rememberToken();
             $table->enum('enum_status', ['active', 'inactive']);
+            $table->string('basic_enum');
+            $table->string('backed_enum');
 
             // Testing property casts
             $table->integer('int');

diff --git a/tests/Type/data/model-properties.php b/tests/Type/data/model-properties.php
@@ -4,6 +4,8 @@
 
 use App\Account;
 use App\Address;
+use App\Casts\BackedEnumeration;
+use App\Casts\BasicEnumeration;
 use App\Group;
 use App\GuardedModel;
 use App\Role;
@@ -43,6 +45,8 @@ function foo(User $user, Account $account, Role $role, Group $group, Team $team,
     assertType(CarbonImmutable::class, $user->immutable_datetime);
     assertType('int', $user->timestamp);
     assertType('\'active\'|\'inactive\'', $user->enum_status);
+    assertType(BasicEnumeration::class, $user->basic_enum);
+    assertType(BackedEnumeration::class, $user->backed_enum);
 
     // CastsAttributes
     assertType('App\ValueObjects\Favorites', $user->favorites);