Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore synthetic keyboard input #387

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

Long0x0
Copy link
Contributor

@Long0x0 Long0x0 commented Mar 23, 2024

Currently when we press alt+tab to switch to a window and release alt before tab, the window gains focus and then receives a tab key.

This leads to the issue lapce/lapce#2612 (same issue in samples/editor).

The KeyboardInput event has an is_synthetic flag to check for this.

Related discussion: rust-windowing/winit#3543 .

@dzhou121 dzhou121 merged commit 942b35a into lapce:main Mar 23, 2024
7 checks passed
@Long0x0 Long0x0 deleted the fix-keyboard-input branch March 24, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants